Fix nameIDPolicyFormat conversion on resource_keycloak_saml_identity_… #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrparkers
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Hi @pablo-ruth, sorry for the delay. I tested this locally and confirmed this fixes the issue described in #773. Thanks for the PR!
I'll merge this as soon as tests pass and push a test change to verify this works in the test suite.
|
Hi @mrparkers, no worries for the delay. And thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #773 by correcting conversion between short and long nameID policy format.